[specimen] save-master-volume bug

[Atte André Jensen]

Lars Luthman wrote:

> It doesn't recall the master volume when restoring a LASH session
> either. That's definitely a bug.

Well I looked into the source (+ a .beef) and it's more like it's not 
implemented than it's a bug. I don't see any attempts anywhere in the 
code to either save or restore the master volume (for instance the 
slider is created directly using the #DEFINEd DEFAULT_VOLUME). Also the 
.beef doesn't seem to know about it, it only has the level of each sample.

While we're at it (just to have in mind when we start working on the 
master volume in the first place): I think controller 7 (master volume) 
should either

1) apply to all samples on the given channel, but without changing the 
set volume of each sample, thus messing up relative levels samples 
inbetween (this also might mean that the channel mentioned in the .beef 
should be exposed (or did I miss something in the gui?)) or

2) apply directly to the master volume (the one we're talking about, the 
one that should be saveable/loadable).

I think 1) makes most sense. Just quickly; the way things are working 
now is that all samples have their individual volumes set directly to 
the received controller 7 value, thus messing up any individual balance 
between the samples. It might just be me, but I fail to see how that 
could be used.

-- 
peace, love & harmony
Atte

http://www.atte.dk      | quintet:      http://www.anagrammer.dk
                         | compositions: http://www.atte.dk/compositions

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.