[specimen] Bug in patch list (0.5.2-rc3)

[Juuso Alasuutari]

On Friday 31 August 2007 15:05:52 Nedko Arnaudov wrote:
> Juuso Alasuutari <iuso at sourcemage.org> writes:
> > On Thursday 30 August 2007 10:21:44 Juuso Alasuutari wrote:
> >> The patch list in 0.5.2-rc3 acts differently than in 0.5.1. When I load
> >> a file with lots of patches the list will expand to show them all,
> >> growing the Specimen window taller than my desktop's height. Something
> >> in 0.5.2-rc3 seems to have disabled the normal scrollbar functionality.
> >
> > I looked at the changes after 0.5.1 and found out that a line removed
> > from src/gui/patchlist.c in 0.5.2-rc2 caused this. The removal was part
> > of Nedko Arnaudov's patch to make windows resizable (rev 42).
> >
> > An unfortunate consequence was that the window size would forcedly grow
> > to accommodate the patchlist's height when new patches are added.
> > Re-adding the removed line will fix it, making the patchlist again
> > scrollable while still keeping the window resizable.
> >
> > Here's a patch that works against latest SVN (rev 53) and 0.5.2-rc3.
> >
> > BEGIN
> > PATCH------------------------------------------------------------------
> > --- src/gui/patchlist.c~	2007-08-31 13:03:15.000000000 +0300
> > +++ src/gui/patchlist.c	2007-08-31 13:03:24.000000000 +0300
> > @@ -115,7 +115,8 @@
> >      gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(self->patch_tree),
> > FALSE);
> >      gtk_tree_view_set_vadjustment(GTK_TREE_VIEW(self->patch_tree),
> >  				  gtk_range_get_adjustment(GTK_RANGE(self->vscroll)));
> > -
> > +    gtk_widget_set_size_request(self->patch_tree, LIST_WIDTH, 1);
> > +
> >      gtk_box_pack_start(box, self->patch_tree, TRUE, TRUE, 0);
> >      gtk_box_pack_start(box, self->vscroll, FALSE, FALSE, 0);
> >
> > END
> > PATCH--------------------------------------------------------------------
> >
> > By the way: Would I qualify for SVN access? I'd love to hasten the next
> > stable release.
>
> Because refered change was caused by patch of mine I verified that this
> patch does not break things here. I can even reproduce the bug with
> ion3 float workspace (that I rarely use). So please commit this patch.

Hi. I changed my list email address to celebrate my newly granted SVN 
access. :) This patch is now applied (rev 54).

Juuso

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.